17:00:22 <nickm> #startmeeting network team meeting, last of 2016!
17:00:22 <MeetBot> Meeting started Mon Dec 19 17:00:22 2016 UTC.  The chair is nickm. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:22 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
17:00:26 <nickm> hi all!
17:00:30 <nickm> last meeting of the year, I hope.
17:00:36 <nickm> NOT planning to do one on boxing day.
17:00:46 <isabela> hehehe
17:01:04 <dgoulet> nickm: good call
17:01:14 <nickm> so, over the past week I merged all kinds of stuff, found a bug with libFuzzer, fixed it, put out security releases, and worked on guards, and merged guard stuff,
17:01:17 <isabela> yall know week from xmas til new years is off
17:01:47 <nickm> and we all did triage, and later today or early tomorrow I'm putting out 0.3.0.1-alpha
17:02:06 <nickm> and for the rest of the week I'm going to try smaller 030 stuff, and finally try to get fuzz support merged
17:02:13 <nickm> and whatever else folks need
17:02:20 <nickm> oh, and also clean up the older stable branches
17:02:34 <nickm> and encourage people to apply for the open position on the team! We're taking resumes till 31 Dec!
17:02:40 <nickm> and that's all for me
17:03:07 <nickm> who else is here today? I see dgoulet and isabela . I know asn just got back to europe and might be tired. Yawning might or might not be around.
17:03:14 <nickm> chelseakomlo said she wouldn't be able to make it.
17:03:52 <dgoulet> hello! Worked on finishing what was left of the prop224 relay support which #19043 is merged and #20029 is in need_review, multiple prop224 ticket for 030 also have been addressed
17:04:04 <dgoulet> some triage ofc as we all know!
17:04:06 <nickm> cool
17:04:18 <isabela> i think it will be a small meeting - armadev is sick too
17:04:19 <nickm> btw, somebody on the blog asked when next-gen hs work would be done. I said "2017, I hope!"
17:04:24 <nickm> that's the plan, right?
17:04:34 <dgoulet> yes hard deadline is July ;)
17:04:41 <dgoulet> by the end of R is our goal
17:04:48 <dgoulet> and we'll pull it off, I'm confident
17:04:52 <isabela> thanks for doing the triage last week o/
17:05:41 <isabela> I am working on repors and proposals and helping with other misc stuff in the org side
17:05:47 <dgoulet> I'll be starting some prop224 service/client work as well in the coming weeks as it's the last phase of all this
17:06:00 <isabela> but! fyi i will be off next week and the week after - parents will be in town hanging out
17:06:12 <isabela> i will be checking things from time to time tho
17:06:21 <dgoulet> (oh and ailanthus is going over the 0.2.9.8 stable blog post I did)
17:06:42 <dgoulet> isabela: very nice, CCC next week anyway :)
17:06:50 <isabela> indeed
17:07:05 <Yawning> hi ish
17:07:29 <nickm> hi-ish Yawning !
17:09:13 <isabela> quick question - how you feel about the 'after triage' state of things? is all looking good? are ppl thinking of doing another round of clean up?
17:09:31 <isis> morning
17:09:53 <dgoulet> 91 ticket in 030 is I think a good state for now for sure
17:10:00 <dgoulet> you know instead of 291 :P
17:10:04 <isabela> ahaha
17:10:34 <nickm> I think we're probably going to have to assign points, grab tickets, and see what's absolutely critical.
17:10:49 <isabela> should i try to review the load distribution there?
17:11:29 <isabela> nickm: yeah that is what i am talking about
17:11:46 <nickm> I don't think that there's so much to review right now; we're kinda recovering from stuff.
17:11:51 <isabela> we should look into starting doing that part and check if the work load is distributed ok
17:11:54 <nickm> maybe we could take some time to assign points and accept things?
17:12:08 <isabela> sounds good
17:13:26 <nickm> isabela: could you send an email to network-team about that?
17:13:32 <isabela> yep
17:13:37 <nickm> or, i could try to fill in points today, and then you could email
17:13:41 <isabela> i will try to coordinate it via email slowly
17:13:53 <isabela> till we are all back from holidays CCC etc
17:16:01 <nickm> woo
17:16:06 <nickm> ok, anybody else for today?
17:16:09 <nickm> any discussion stuff?
17:16:12 <nickm> could be a short meeting!
17:16:19 <isabela> !
17:16:27 <dgoulet> are you guys OK with the blog postbtw?
17:16:45 <dgoulet> ailanthus just finished few passes on it to fix some issues
17:17:34 <nickm> I haven't read it; do you like it?
17:17:38 <nickm> if so it's probably great
17:17:46 <dgoulet> yeah I like it and asn read it also
17:17:59 <dgoulet> not very long, just outlines the single onion and shared random
17:19:31 <asn> hello people. just woke up from a nap in a new continent! last week was mainly busy with reviewng guard code and writing crowdfunding blog posts.
17:19:33 <nickm> maybe mandatory-ntor?
17:19:43 <nickm> asn: wooo, thanks for that so much!
17:19:58 <asn> this week i plan to work on #20852, and keep on auditing guard logs.
17:20:12 <nickm> I have a request for that code!
17:20:18 <nickm> Did you see the #21018 stuff ?
17:20:31 <asn> a little bit yes
17:20:44 <nickm> basically, one half of the fix was actually fixing the bug
17:20:56 <nickm> and the other half was making sure that the intro-point string that we parse is nul-terminated...
17:21:04 <nickm> ...so that even if there's another bug like this, it can't bite us.
17:21:08 <asn> right
17:21:29 <nickm> Could you please make sure that the descrypted intro point string is nul-terminated before we parse it for the v3 hsdesc stuff too?
17:21:43 <asn> ack
17:21:55 <Yawning> (oh was I supposed to do a report? I sent e-mail instead)
17:21:55 <asn> does the fix code also change v3 stuff?
17:21:59 <Yawning> sorry not entirely awake yet
17:22:10 <nickm> asn: the bug fix _should_ fix all parsing.
17:22:13 <asn> ok
17:22:17 <asn> i can take a look tomorrow
17:22:32 <asn> to ensure correct v3 behavior
17:22:39 <nickm> asn: but I didn't change any hsdir intropoint stuff for prop224, since that's in flux, and my understanding is that it isn't used yet.
17:22:55 <nickm> (Is that right?  That is, nobody should ever be decrypting intro points at all right now, much less parsing them, right?)
17:23:10 <nickm> (has everybody seen Yawning's email? any questions for him?)
17:23:17 <dgoulet> nickm: it is NUL terminated in v3
17:23:21 <nickm> (maybe a good idea to summarize here since the email wasn't published)
17:23:22 <dgoulet> if (tokenize_string(area, start, start + strlen(start),
17:23:38 <Yawning> (I don't pander to the public)
17:23:38 <nickm> dgoulet: that's the hidden service, or the intropoints?
17:23:48 <nickm> Yawning: (you write free software.)
17:23:49 <dgoulet> nickm: IPs from the descriptor
17:24:05 <dgoulet> nickm: and yes that part is NOT used in 030 anyway
17:24:07 <nickm> dgoulet: could you point me towards the function?
17:24:24 <dgoulet> nickm: "decode_introduction_point()"
17:24:26 <asn> (not sure which yawning email we are referring to)
17:24:29 <dgoulet> nickm: hs_descriptor.c
17:25:00 <dgoulet> nickm: decode_intro_points() is the top level, we reconstruct IPs section
17:25:19 <dgoulet> nickm: the second place is desc_decode_encrypted_v3() which might be problematic
17:25:49 <dgoulet> decrypted[encrypted_len] = '\0';
17:26:26 <nickm> seems ok to me, since you allocated that byte.
17:26:34 <dgoulet> I have no Yawning email...
17:26:42 <Yawning> what
17:26:47 <Yawning> I sent that shit to network-team@
17:26:53 <nickm> sent to network-team, 8 hours ago?
17:27:02 <Yawning> <20161219085153.2c480f03@schwanenlied.me>
17:27:27 <dgoulet> I doN,t have that mail in my Inbox :S
17:27:31 <nickm> asn: btw, do you have time to look at a 3-line guard patch for #21007 ?
17:27:35 <Yawning> tldr: I did sandbox shit, I will keep doing sandbox shit till the end of the year, at which point funding realitis have me doing tor shit instead
17:27:48 <dgoulet> Yawning: so much "shit" :P
17:28:55 <asn> nickm: right now i dont have brain or time for review. i can take care of it tomorrow as well.
17:29:14 <asn> (noted #21007)
17:29:15 <dgoulet> Yawning: that one "Re: [network-team] Team meeting tomorrow Dec 19th at 1700 UTC" ??
17:29:28 <dgoulet> Yawning: ok yeah that one matches the msgid
17:30:40 <asn> ah yeah i read that email as well
17:30:41 <nickm> asn: actually I'll just merge it.  It's kinda straightforward, and it fixes a warning that will be totally obnoxious.  But I'll leave it in needs_review :)
17:30:56 <asn> ok i'll take a look tomorrow my morning
17:30:59 <nickm> thanks!
17:31:05 <nickm> any more for today?
17:31:09 <asn> Yawning: what kind of tor shit are funding realities pointing you to?
17:31:16 <Yawning> uh
17:31:27 <Yawning> p sure it starts with support for the fragmented create cells
17:32:26 <asn> ack
17:32:34 <Yawning> ask me when I'm actually awake and not typing on autopilot
17:33:17 <nickm> sounds like we're running low on discussion things?
17:33:22 * dgoulet is good
17:33:38 <dgoulet> I assume you are good with the blog post so will publish this sometime today
17:34:03 <nickm> sure!
17:34:03 <Yawning> I assume, any core tor stuff that people want me to do can wait till thge next calendar year
17:34:17 <Yawning> because there is sandbox stuff that I want to do while I still have time for it
17:34:59 <nickm> dgoulet: I'd like it to cover even more, but I don't feel so strongly that I'm about to write it myself, so.... ;)
17:36:26 <dgoulet> nickm: we have so much lol, I could add a section on the mandatory ntor
17:36:34 <dgoulet> quite easy to do
17:36:36 <nickm> if you like!
17:36:37 <nickm> thanks!
17:38:38 <nickm> #endmeeting