18:00:25 <GeKo> #startmeeting tor browser dev
18:00:25 <MeetBot> Meeting started Mon May  2 18:00:25 2016 UTC.  The chair is GeKo. Information about MeetBot at http://wiki.debian.org/MeetBot.
18:00:25 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
18:00:34 <GeKo> hi everybody!
18:00:42 <mcs> hi!
18:00:54 <GeKo> let's get started with some status updates. i guess i go first today
18:01:21 <GeKo> last week i helped getting the releases out including the alpha one which hit several worst cases
18:01:28 <GeKo> but still we made it, yay
18:01:45 <GeKo> there is some fallout it seems but that was kind of expected i guess
18:02:17 <GeKo> then I investigated #18915 and started writing a patch
18:02:39 <GeKo> i got distracted by two buffer overflows i saw in my asan builds
18:03:00 <GeKo> only one i was able to reproduce
18:03:09 <GeKo> the good news is it does not affect esr38
18:03:28 <GeKo> but it seems esr45 is affected on all sec slider levels
18:03:45 <GeKo> we'll see if mozilla thinks this is as serious as it seems
18:04:13 <GeKo> then i looked over the tickest and started with the usual admin stuff at the beginning of a new month
18:05:14 <GeKo> i made further progress on reviewing fixed mozilla bugs but am not done with that one yer
18:05:15 <GeKo> *yet
18:06:07 <GeKo> this week i'll write a patch for #18915 and continue reviewing moz bugs
18:06:16 <GeKo> we'll see what else comes up
18:06:38 <GeKo> hopefully openssl does not blow up in a way that we need to make new releases
18:06:45 <GeKo> that's it for me
18:07:05 * mcs will go next
18:07:10 <mcs> Last week, Kathy and I did some testing of 6.0a5 and we found and fixed a couple of last minute issues: #18899, #18900.
18:07:19 <mcs> We also sent some info about the Tor Browser updater code and our patches to Sukhbir (Tor Messenger team).
18:07:24 <mcs> We made another pass through the Firefox release notes and developer docs for #18545.
18:07:32 <mcs> Finally, we filed #18928 and spent some time debugging it.
18:07:38 <mcs> This week, we plan to work on various TB 6.0 issues including #18928 and #18947.
18:07:42 <mcs> Also, Kathy and I will both be away-from-keyboard this Thursday and Friday.
18:07:47 <mcs> That’s all for us.
18:08:22 <mcs> By the way, thanks to boklm and GeKo for their hard work to get all of the release work done.
18:08:34 <GeKo> you are welcome, thanks
18:08:59 <mcs> (that is kind of a thankless job, so I thought I would say thanks)
18:09:05 <GeKo> what is the plan for #18904?
18:09:24 <mcs> Oh, I half forgot about that one.
18:09:30 <mcs> We will need to make a plan.
18:09:42 <GeKo> i thought so :)
18:09:53 <mcs> I made a note ;)
18:10:06 <GeKo> sounds smart :)
18:12:04 * arthured1lstein can go now
18:12:06 <arthured1lstein> hi everyone
18:12:22 <arthured1lstein> Last week was a short week for me as I took a couple of days off.
18:12:27 <arthured1lstein> I wrote a patch for #18905.
18:12:36 <arthured1lstein> I also worked on #18886 and started working on #18884 (which is similar).
18:12:44 <arthured1lstein> And I posted a patch for #18703 and a possible one for #18743.
18:13:02 <arthured1lstein> This morning I have been reading over the OTF proposal and will send my comments this afternoon.
18:13:17 <arthured1lstein> And this week I will work on #18884 aand #18886 further and try to finish up a better patch for #16998.
18:13:37 <arthured1lstein> That's it for me.
18:15:08 * boklm will go next
18:15:21 <boklm> This past week I published the new releases.
18:15:25 <boklm> I fixed the testsuite for ESR45 builds (#18887). (Unfortunately too late to find #18915 in 6.0a5)
18:15:33 <boklm> I made some changes to the tests for ESR45: https://lists.torproject.org/pipermail/tbb-dev/2016-May/000372.html
18:15:47 <boklm> For this week, I still have #18597 in my todo list. I'm also planning to take a few days off, from wednesday to the end of the week.
18:15:57 <boklm> That's it for me.
18:17:18 <mikeperry> ah, there is a ticket for pocket. good
18:17:46 <mikeperry> here's some stuff for me:
18:18:10 <mikeperry> Wrt 6.0a5, the UI still has an empty save to pocket UI element. Not sure what pocket is, but in the past I've removed stuff like this by customizing the UI from the vent and saving the new value of browser.uiCustomization.state to our prefs. Torbutton also has some logic to update this pref as well, especially when we change it.
18:18:15 <mikeperry> There is a similar issue with the Reader button. I am not sure about the Reader mode. Maybe we disable it somehow if we haven't audited it for tracking safety?
18:18:18 <mikeperry> I also need to look into Windows sandboxing. If anyone knows anything about Windows sandboxing and can throw some URLs at me for later, that would be helpful. (I'm especially wondering if it is possible to make #14270 work for Windows by making a named-pipe version of the SocksSocket option for tor on Windows, and then removing the browser's ability to do networking.
18:19:03 <mikeperry> I guess the pocket pref may be better than the UI editing
18:20:04 <mikeperry> that's it for me. happy for input on Windows from anyone with any info
18:20:09 <mcs> Mozilla seems to have made a mess with the Pocket integration but they moved it into a separate extension now (for Firefox 46).
18:20:51 <GeKo> so, the pref for sharedworkers is gone but as far as i can see we should be good anyway due to #15564, right?
18:21:34 <GeKo> yeah, the reader moder
18:21:37 <GeKo> *mode
18:21:38 <arthured1lstein> mikeperry: It turns out that the pocket prefs are not enough to make the menu items disappear. One option I have tried is to rip out all the pocket code from tor-browser.git
18:21:53 <arthured1lstein> But the other possibility is to disable pocket and hide the UI items
18:22:22 <boklm> GeKo: yes, in 5.5, we were checking that the pref was set to true (with #15564)
18:22:58 <GeKo> arthured1lstein: i think the latter is fine. bonus points if the ui items are bound to the pref, too
18:23:44 <GeKo> like it does not get shown in the bookmarks drop down menu if it is disabled
18:23:57 <GeKo> but shows up when it is enabled
18:24:08 <GeKo> but if that's too much effort just hide it
18:24:55 <arthured1lstein> When bonus points are in play, no effort is too much!
18:25:24 <GeKo> hehe
18:25:26 <arthured1lstein> But should be quite doable I think
18:25:42 <arthured1lstein> I guess we should tie the UI to the Mozilla pref?
18:25:52 <GeKo> yes
18:26:00 <GeKo> at least that would make sense to me
18:26:28 <arthured1lstein> OK, will do
18:27:20 <GeKo> who else is here for a status update?
18:28:48 <GeKo> do we have anything to discuss?
18:29:27 <mcs> When will we know about the openssl thing?
18:29:30 <GeKo> my current plan is to retriage bugs next monday for the remaining two weeks before we get the stable out
18:29:33 <GeKo> tomorrow
18:29:36 <mcs> OK
18:30:02 <mcs> I am just thinking it might be good to have fixes in hand for some 6.0a5 fallout in case we need to release due to openssl
18:30:18 <mcs> We will see how it goes.
18:30:35 <GeKo> yes, that was one reason why i mentioned openssl in the first place :)
18:30:44 <mcs> :)
18:31:43 <GeKo> alright, thanks everybody *baf*
18:31:47 <GeKo> #endmeeting