18:00:58 <GeKo> #startmeeting tor-browser
18:00:58 <MeetBot> Meeting started Mon Apr 25 18:00:58 2016 UTC.  The chair is GeKo. Information about MeetBot at http://wiki.debian.org/MeetBot.
18:00:58 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
18:01:06 <GeKo> hello everyone!
18:01:15 <arthuredelstein> hi!
18:01:18 <GeKo> and welcome to a new tor-browser meeting
18:01:27 <GeKo> who wants to go first today?
18:01:42 <nickm> Yawning: yeah, that'll work fine.
18:03:10 <GeKo> it seems this falls back to me again, fine.
18:03:40 <GeKo> alright, last week i was busy preparing the releases and addressing things found in the network review
18:03:42 <Yawning> (k)
18:04:07 <GeKo> i am quite happy with the 6.0a5 outcome, we basically got all of the things in we wanted, somehow at least
18:04:14 <GeKo> thanks everybody
18:04:41 <mcs> Thanks to you for pulling it all together!
18:05:09 <GeKo> this week i'll help getting the releases out, then i plan to look at all the firefox bugs that did not make it into the dev docs
18:05:12 <GeKo> thanks
18:05:24 <arthuredelstein> yeah, thanks for spending your weekend on it, GeKo!
18:05:39 <GeKo> and i reserve some time for things that explode
18:06:04 <GeKo> boklm helped here, too, fwiw
18:06:14 <GeKo> so, i am glad, we made it :)
18:06:39 <GeKo> today i looked at the remaining esr tickets, i guess we can talk later about how to proceed
18:06:47 <GeKo> that's it for me for now
18:07:02 * mcs will go next
18:07:07 <mcs> Last week, Kathy and I created fixes for #18800 and #18603.
18:07:17 <mcs> We reviewed many, many ESR45 fixes.
18:07:24 <mcs> We also spent some time on #18619 but did not find the root cause of the browser console messages.
18:07:32 <mcs> This week we will work on other tickets that have keyword=ff45-esr.
18:07:42 <mcs> (I guess we will talk later about how to divide up the tickets)
18:07:48 <mcs> That’s all for now.
18:08:03 * arthuredelstein can go now
18:08:09 <arthuredelstein> Last week I worked on patches for #16326, #18741, #16998, and #16673.
18:08:22 <arthuredelstein> This week I will work on a better patch for #16998, reviewing our patch for #15640, and trying to fix #18743.
18:08:41 <arthuredelstein> If I have more time I'll try to work on more ff45-esr patches.
18:08:59 <arthuredelstein> That's it for me
18:10:17 * boklm will go next
18:10:34 <boklm> This past week I fixed #17895, reproduced builds of the new releases, and started looking at #18887
18:10:43 <boklm> This week I planning to fix #18887 to get the test suite working with ESR45, and help getting the releases out
18:10:53 <boklm> That's it for me.
18:13:48 <GeKo> hm. releasing without running the tests what could go wrong :)
18:14:09 <GeKo> but i guess we don't have good alternative options
18:15:30 <GeKo> mcs: a second look at the dev doc things in #18545 would be helpful in case i overlooked something
18:16:03 <mcs> GeKo: I forgot about that. Kathy and I will take a look.
18:16:12 <GeKo> maybe putting that on the agenda for this week because if i messed up we would still have time to fix stuff
18:16:18 <GeKo> thanks
18:16:28 <GeKo> who else is herer for a status update?
18:16:46 <GeKo> *here
18:17:33 * GeKo suspects mikeperry is here but probably being shy
18:18:51 <GeKo> anyway, i heard the network code review is done and there are two remaining things we need to look closer at
18:18:52 <GeKo> thanks mike
18:19:00 <GeKo> i plan to do that this week
18:19:22 <GeKo> okay, discussion time
18:19:36 <GeKo> first item on my list: reminder of deadlines
18:19:50 <GeKo> i forgot to mention that last week which is my bad
18:20:13 <GeKo> but we had this discussion in the past: deadline for patches should be thursday the week before the release
18:20:31 <GeKo> given that we usually need at least one who is reviewing the code
18:20:54 <GeKo> sometimes two reviewers are required in case the code is complicated c++
18:21:06 <GeKo> there are exceptions to this rule
18:21:41 <GeKo> but generally aiming for monday or the weekend for patches is not a good idea :)
18:21:53 <arthuredelstein> makes sense to me :)
18:22:08 <GeKo> i try to remember announcing things the next time, though :)
18:22:23 <GeKo> second item: when do we want to get the stable out?
18:22:29 <mikeperry> I am here, but distracted
18:22:36 <GeKo> aha! welcome!
18:22:39 <mikeperry> is there something needed from me?
18:22:54 <GeKo> i think we are fine, i just summarized your status update
18:23:09 <GeKo> (the network review being done)
18:23:40 <mikeperry> oh yeah. yep. that's finally over :)
18:24:38 <GeKo> i am trying to remember what we did last time. i guess it was a soft launch one or two weeks before the EOL of esr31
18:24:58 <GeKo> that sounds again like a good idea to me
18:25:32 <mcs> So “soft launch” means available for use but we do not enable updates?
18:25:44 <mcs> Seems like a good thing to do again.
18:27:17 <boklm> based on esr 45.1 ?
18:27:31 <GeKo> yes, based on 45.1
18:28:05 <GeKo> i wonder about the update thing, though. i guess it would not be a soft launch if we enabled updates
18:28:39 <GeKo> even if we would not urge user to update given that this is no security related update
18:30:39 <GeKo> so looking at the timeframe week 21 May 25-29 seems to okay?
18:31:10 <GeKo> i guess we want to have some time for fixing urgent things we did not catch with our tests/the alpha
18:31:12 <mcs> “soft launch” could mean we update but also tell people that it is OK to continue to use 5.5.x (and they could downgrade if 6.0 is really bad for them)
18:31:43 <GeKo> yeah, i might be more inclined to that model
18:32:30 <GeKo> but the release date should be unaffected by the update/no update question
18:32:41 <mcs> Also note that May 30th is Memorial Day in the US (aka summer kickoff for a lot of people)
18:33:05 <mcs> (Kathy and I will be afk that weekend including Monday the 30th)
18:33:09 <arthuredelstein> How do we tell people these things (whether or not to update)? Is it something we can do in the UI?
18:34:42 <GeKo> mcs: ok. does that speak for releasing before it or after it?
18:34:55 <mcs> There is a way to mark an update as not critical / not a security update but we have never done that (I don’t remember exactly how that changes the behavior of the UI).
18:35:29 <mcs> When is ESR38 EOL? One week after that?
18:35:48 <GeKo> June 7
18:36:24 <mcs> If we can get everything done in time, earlier release might be smarter. I don’t know.
18:37:11 <GeKo> let's aim for May 23-27
18:37:42 <mcs> So patches need to be done by May 19.
18:38:12 <GeKo> well we are flexible here given that we don't have a fixed release date on tuesday :)
18:38:41 <mcs> True.
18:39:46 <GeKo> but having all patches done by May 22 leaving possible reviews and release preparations for that week
18:39:49 <GeKo> sounds like a good plan to me
18:40:32 <arthuredelstein> me too
18:40:35 <boklm> yes, sounds like a good plan
18:41:28 <mcs> Let’s try to get the tricky patches done earlier ;)  Kathy says “earlier is better.”
18:41:45 <GeKo> yes, agreed. looking at the tickets tagged with ff45-esr that should be doable
18:42:14 <GeKo> this week we should get all the mozilla bug reviews done
18:43:37 <arthuredelstein> One way to get only some people updating (a soft launch) would be to not show the Update warning (and big black arrow) on the about:tor page. But the "Check for tor update" menu option would still result in an update. But I guess that requires a modification to torbutton?
18:43:51 <GeKo> mcs: #18770 sounds like it might take some time as well
18:44:30 <GeKo> arthuredelstein: no, we only need to add the new version to the RecommendedTBBVErsions file but not remove the old, i.e. still current one
18:44:42 <GeKo> that's was actually my plan
18:45:26 <arthuredelstein> GeKo: Ah, ok - so that results in not showing the update warning on about:tor?
18:45:49 <GeKo> yes. it is only shown if the version you are running is not in that file
18:45:54 <GeKo> which torbutton fetches
18:46:04 <arthuredelstein> great
18:46:25 <GeKo> arthuredelstein: #18811 might be one candidate for getting done earlier as well
18:47:05 <arthuredelstein> good suggestion. I'll aim to work on that soon.
18:47:45 <GeKo> apart from that nothing is actually jumping out for a early as possible treatment
18:48:03 <GeKo> but i guess looking at it again next week after the update might be a good idea
18:49:00 <GeKo> that were my discussion items. do we have something else/additional comments?
18:49:46 <mcs> I would say anyone who starts to work on a ticket should make themselves the owner so we avoid overlap
18:50:04 <mcs> (for the ff45-esr ticket effort)
18:50:15 <GeKo> good idea, yes, please
18:50:18 <arthuredelstein> yes
18:52:53 <GeKo> okay, thanks for the meeting then. just a final thing:
18:54:15 <GeKo> i looked at our 38.1.0 branch because i was curious whether we have to deal with less patches now that another ESR cycle is almost over
18:54:45 <GeKo> it turns out, no, we are starting with almost the same amount of patches as back then which is :(
18:55:00 <GeKo> but, hey, what did i expect :)
18:55:03 <GeKo> *baf*
18:55:07 <GeKo> #endmeeting