18:09:42 <sysrqb> #startmeeting TOrBrowser Team Meeting 6 April 2020
18:09:42 <MeetBot> Meeting started Mon Apr  6 18:09:42 2020 UTC.  The chair is sysrqb. Information about MeetBot at http://wiki.debian.org/MeetBot.
18:09:42 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
18:09:58 <sysrqb> err. Tor Browser
18:10:00 <sysrqb> anyway
18:10:02 <sysrqb> hello everyone
18:10:06 <sisbell> hi
18:10:10 <sysrqb> welcome to another text-based meeting
18:10:13 <Jeremy_Rand_Talos> hi!
18:10:49 <pospeselr> o/
18:11:14 <GeKo> huh, did it not work?
18:11:21 <sysrqb> i failed.
18:11:39 <sysrqb> my microphone wasn't recognized
18:11:39 <boklm> hi
18:12:03 <pospeselr> qubes strikes again ;)
18:12:15 <sysrqb> no, just ubuntu
18:12:31 <sysrqb> acat: i odn't think we should prioritize #32006
18:12:34 <sysrqb> *don't
18:13:01 <sysrqb> i'd prefer we concentrate on the testsuite tests and other migration-related tickets
18:13:40 <pospeselr> should I be hopping on the testsuite work once i've gotten all these tasks into trac?
18:13:46 <acat> ok, makes sense
18:13:53 <sysrqb> boklm: have you made progress on making the testsuite operational again?
18:13:59 <pospeselr> or continue on to the rlbox review?
18:14:01 <sysrqb> pospeselr: yes please
18:14:05 <sysrqb> heh
18:14:13 <sysrqb> testsuite should take priority
18:14:30 <sysrqb> although i'd like to get the rlbox patches merged
18:14:40 <sysrqb> hrm. i'll look at them later today
18:14:51 <sysrqb> i dont' actually know how much review the rlbox patches need
18:14:55 <boklm> sysrqb: not yet
18:15:06 <sysrqb> okay
18:15:47 <acat> i guess we'll have to sync with boklm and pospeselr re: testuite tests, i'm not sure what's the state
18:16:07 <acat> so that we don't do the same independently :)
18:16:16 <sysrqb> do you have access to use mozilla's try server?
18:16:29 <acat> i do
18:17:40 <sysrqb> okay
18:17:48 <boklm> we have two kinds of tests: the tests in tor-browser.git (which we can run on mozilla try), and the testsuite which is separate from tor-browser.git (which doesn't work with mozilla try)
18:18:40 <acat> i saw #33791, sysrqb: does this mean we should try to get (a subset of) firefox tests passing in try?
18:19:45 <sysrqb> yeah. we have two blockers of working on the testsuite tests: getting mozilla-central building in tor-browser-build, and fixing the testsuite so it is operational
18:19:58 <sysrqb> we have the small set of tbb-tests in tor-browser.git
18:20:06 <sysrqb> which you can test and make sure those pass
18:20:09 <sysrqb> and fix them if they don't
18:20:29 <sysrqb> and then we also want to document which firefox tests currently fail  and why they fail
18:20:36 <sysrqb> that will be a little painful
18:21:07 <sysrqb> so starting with tbb-tests is probably a better place
18:21:25 <acat> tbb-tests should be fixed with the patch in #30832 (although i'm taking a look at Thorin's comment)
18:22:03 <sysrqb> okay
18:22:38 <sysrqb> another important ticket that i could use help with is #31918
18:23:07 <sysrqb> maybe you want to look at it and try creating a new branch for this
18:23:52 <acat> sysrqb: ok, but just for central, not esr68, right?
18:24:00 <sysrqb> th goal being that we squash related patches where we currently have a patch for desktop-only and another for android-only
18:24:05 <sysrqb> acat: yes, correct
18:24:27 <sysrqb> this sould be much easier now without the fennec pieces
18:24:29 <sysrqb> *should
18:24:50 <sisbell> do we have list of android related patches somewhere?
18:25:08 <sysrqb> only the commits on tor-browser.git
18:25:28 <sysrqb> 'git log mobile/android' should get 90% of them
18:25:37 <sysrqb> there are some more under widget/
18:25:37 <sisbell> ok cool thanks, that helps
18:25:49 <sysrqb> and maybe one or two other directories
18:26:11 <acat> sysrqb: i think the two first categories in https://trac.torproject.org/projects/tor/ticket/33533#comment:1 should be those
18:27:04 <acat> many of them do not apply anymore, because the files are gone from mozilla-central repo
18:27:06 <sysrqb> yes, thanks
18:27:41 <sysrqb> yeah, GeckoView should be a relatively small wrapper now
18:28:19 <sisbell> I'll go through the patches and see which ones can migrate to fenix app
18:29:10 <sisbell> at least in terms of features
18:29:14 <sysrqb> sisbell: none of them will migrate because we're implementing a new UI in fenix
18:29:17 <sysrqb> okay right
18:29:46 <sysrqb> this is work that we'll be working with antonela on designing
18:30:38 <antonela> well, is going to be an aim of feature-parity with desktop
18:31:32 <sysrqb> yes, for sure
18:32:02 <sysrqb> but i think we decided that we are only reaching feature-parity with fennec for the first fenix release
18:32:05 <sysrqb> right?
18:32:18 <antonela> yep
18:32:28 <sysrqb> okay, good :)
18:33:27 <sysrqb> okay, i see Pili wants to remind everyone about submitting their timesheets for March (if applicable)
18:33:33 <pili> yes please :)
18:34:32 <sysrqb> good
18:34:59 <sysrqb> oh. regarding tor browser releases. in case any of you missed it
18:35:08 <sysrqb> there was a firefox chemspill on Friday
18:35:25 <sysrqb> so we released 9.0.8 yesterday, and we're releasing 9.5a10 today
18:35:46 <sysrqb> tomorrow we should release 9.0.9, as scheduled, based on Firefox 68.7.0esr
18:35:58 <sysrqb> and 9.5a11 will probably be released on wednesday
18:36:12 <antonela> will a10 have s27 patches?
18:36:21 <sysrqb> no, only a11
18:36:27 <antonela> ok
18:37:19 <mcs> the s27 patches should be in nightly builds now (I think)
18:37:29 <sysrqb> after 9.5a11 is released we can begin discussing when we should move 9.5 to be the new stable
18:37:32 <sysrqb> mcs: yes, in theory
18:37:46 <sysrqb> except we haven't had a successful nightly build since i merged them
18:38:01 <sysrqb> because of a conflict with one of the namecoin patches
18:38:17 <sysrqb> so the biulds fail at compile-time in nightly-only
18:38:28 <Jeremy_Rand_Talos> sysrqb, sorry for the delay reviewing the conflict fix patch, I should be able to look at it later today
18:38:32 <sysrqb> #33807 should fix that today
18:39:04 <sysrqb> Jeremy_Rand_Talos: no worries, your patches are upstreamed so we should fix it
18:39:15 <sysrqb> boklm wrote a patch already
18:40:49 <sysrqb> does anyone else have comments/questions/concerns we should discuss during this meeting?
18:41:03 * sysrqb doesn't see any on the pad
18:41:13 <Jeremy_Rand_Talos> a minor one
18:41:39 <sysrqb> sure
18:41:48 <Jeremy_Rand_Talos> If anyone would like to review my patch for #33749, it would help one of the Namecoin testers give useful feedback
18:41:55 <sysrqb> (please mark it on the pad in the future :) )
18:42:11 <Jeremy_Rand_Talos> Yes, sorry, forgot to mark that one on the pad
18:43:34 <Jeremy_Rand_Talos> there, retroactively added to pad :)
18:43:38 <sysrqb> i'll find someone to review it
18:43:44 <Jeremy_Rand_Talos> thanks sysrqb
18:43:47 <sysrqb> thansk L(
18:43:49 <sysrqb> err
18:43:50 <sysrqb> :)
18:44:00 <sysrqb> okay
18:44:11 <sysrqb> i think that concludes this meeting
18:44:25 <sysrqb> have a good week everyone, and safe safe/healthy/sane
18:44:31 <sysrqb> *stay safe
18:44:32 * Jeremy_Rand_Talos will look into buying a less crappy headset
18:44:37 <Jeremy_Rand_Talos> thanks!
18:44:39 <sysrqb> #endmeeting