17:30:26 #startmeeting Tor Browser Meeting 2019-09-16 17:30:26 Meeting started Mon Sep 16 17:30:26 2019 UTC. The chair is sysrqb. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:30:26 Useful Commands: #action #agreed #help #info #idea #link #topic. 17:30:32 Hello everyone! 17:30:44 hi 17:30:48 <_hc> hello! 17:30:49 <_hc> I made it! 17:30:52 hi 17:30:55 hi! 17:30:58 GeKo decided I can try running this meeting :) 17:31:26 _hc welcome welcome 17:31:46 o/ 17:31:48 o/ 17:32:22 hi 17:33:02 the usual pad - https://storm.torproject.org/shared/tHoN4Ii7rLSjPE0OP4gydX4cMGadsXmRQNc-6lwru0N 17:34:00 hi, only 50% here for now... sorry 17:34:47 * tjr is in a meeting so is not paying attention much 17:35:07 okay, seems we're missing sisbell and pospeselr ? 17:35:20 I just added it, so try refreshing 17:35:33 great, i see it now, than 17:35:35 thanks 17:35:58 Okay, GeKo, i think you're up first :) 17:36:10 okay 17:36:36 i was wondering whether anyone has opinions about how to proceed 17:36:45 with making tor browser working for macos 10.15 17:37:07 it think i have a signing setup ready if need be 17:37:23 and we should get out new osx bundles 17:37:35 before catalina goes life 17:37:42 live 17:37:52 which is supposedly to be in october 17:37:57 Unfortunately, while Apple switched the release date for macOS 10.15 Catalina from September to October they did not give a specific date (not surprising). 17:38:08 yeah 17:38:17 we still need to backport one patch 17:38:29 so, mozilla does not want to support esr60 here 17:38:51 and without the patch the browser is essentially unusable on macOs 10.15 17:38:57 it crashes quickly 17:39:06 so we might be on our own here 17:39:24 on esr60? 17:39:25 however, it seems we could easily release new alpha bundles with it 17:39:31 yes 17:39:35 this is until we release 9.0? 17:39:38 (stable) 17:39:41 yes 17:39:53 as catalina is probably getting out earlier 17:40:06 Should we wait and include it in our end-of-September alpha? 17:40:21 yeah, that's one option 17:40:39 then there might be a 68.1.2 point release 17:40:53 i mean mozilla wants to get this fixed as well 17:41:02 for esr68 before oct i guess 17:41:12 so, maybe we wait for that one here 17:41:21 depending on which comes earlier 17:41:21 sounds good to me 17:41:30 okay, 17:41:58 so we test the macos compat either in our planned alpha 17:42:14 or in an alpha beased on 68.1.2esr depending on what comes earlier= 17:42:16 ? 17:42:28 hoping that we still have enough time to react for stable? 17:43:12 and we backport the needed patch(es) for the next release? 17:43:17 for stable 17:43:24 yes 17:43:31 okay 17:43:38 the alternative to that plan would be 17:43:46 we get an alpha release just for macos out asap 17:43:56 to test the macos signing and 10.15 compat 17:44:08 and get, say, 8.5.7 outnext week 17:44:22 just for macos with just the signing related patch 17:44:35 (that goes for both alpha and stable) 17:44:51 that would get us rid of the lingering notarization problem 17:44:54 i guess it depends on availability, given mcs and brade are afk next week 17:45:02 but it costs us additional releases 17:45:29 Maybe we can find someone else who has a 10.15 set up? But I am not sure who. 17:45:32 which means additional resources get away from esr68 transition work 17:45:39 do people usually upgrade quickly to the next macos release? 17:45:54 dunno 17:45:55 I don't have 10.15 yet 17:46:04 I could upgrade if necessary though 17:46:14 i mean we already had a bunch of reports that stable was broken on early macos *betas* 17:46:33 pili: It is still in beta test, which means enrolling in Apple’s beta test program to get the OS 17:46:36 so i don't want to be on anything here 17:46:42 *bet 17:46:47 ah 17:46:48 hmm, I think I'm good ;) 17:47:17 especially as i still don't know what happens if users upgrade but still have an unnotarized tor browser around 17:47:18 I would expect a lot of people to upgrade to 10.15 as soon as Apple releases it. I am not sure how many “a lot” is though. 17:47:23 does that one suddenly break? 17:47:28 yeah 17:47:43 i think "a lot" is enough that we should care hee 17:47:44 so if we don't add support to esr60, we'll have no stable release available there between 0 and 22 days? 17:47:48 *here 17:48:06 I don’t think the old one will break but I am not 100% sure (and Apple could even change something before the final 10.15 release). 17:48:17 boklm: what do you mean? 17:49:19 depending when they release 10.15 in october, there will be between 0 and 22 days until the 9.0 release 17:49:39 GeKo: how much time is involved with backporting the patches? 17:50:07 it's just one we need 17:50:23 it's not large 17:50:32 but it does not apply cleanly 17:50:39 that's all i know for sure 17:50:45 okay 17:50:55 but i'd assume it at most a couple of hours 17:51:06 including testing that we not messed up 17:51:30 boklm: yes 17:51:48 it sounds like we should plan on a release next week or the following week - depending on our ability to test it 17:52:03 i think betting on no esr60 release anymore is not smart 17:52:17 sysrqb: you mean for an alpha? 17:52:57 yes, plus backporting the patch and included it in the next 60esr-based relesae 17:53:11 okay 17:53:24 so, this is essentially option one we discussed aboev 17:53:25 but it seems like those will be different release, 17:53:26 sounds good 17:53:31 yes 17:53:55 i'll monitor the esr68 branch closely and probably ask mozilla folks about a point release for esr68 17:54:00 so we have better planning here 17:54:04 sounds good 17:54:05 okay 17:54:16 that's it from me for the group 17:54:25 as for #31010, i'll chat with acat about that 17:54:54 msc, brade: you saw GeKo had a question for you? 17:55:00 we don't need to discuss it here, though 17:55:13 okay, let me know whee we are 17:55:20 i might give some pieces a second review 17:55:25 i am not sure yet 17:55:42 sisbell: did you want to discuss that? #31564 17:56:02 GeKo: okay, i'll take whatever you give me :) 17:56:33 Yes. I implemented it and verified checksums match on my machine but I just need verification across some different machines to see if checksums match 17:56:59 i can help with that this week 17:57:00 that's basically it 17:57:04 when i review and test you branch 17:57:22 GeKo: sounds good, thanks 17:57:33 sysrqb,GeKo: I answered your question on the pad. 17:57:44 sisbell: could you start with the x86_64 patches? 17:57:47 sisbell: do you think you'll have time for #31192 this week? 17:57:53 heh, beat me to it 17:57:53 heh 17:58:04 yeah, that's pretty important 17:58:11 Sure, I'm lite on issues now so I'll start on that one 17:58:14 and we should get an alpha at least to test it 17:58:25 i didn't realize it, but Android/Google Play basically uninstall Tor Browser on x86 devices 17:58:37 because we didn't ship updates for it 17:58:52 Google knows best 17:58:53 so, that's not good 18:00:24 okay, does anyone want to discuss anything else related to weekly updates? 18:00:44 sysrqb: i think acat had something? 18:00:57 at least it's highlighted there 18:01:04 (not sure who did that, though) 18:01:19 ah, for pospeselr ? 18:01:22 just asking pospeselr if it's fine to take #31303 18:01:22 acat: please feel free 18:01:24 yeah 18:01:25 ok 18:01:37 okay, good good 18:01:42 anything else? 18:02:00 okay, moving on to discussions 18:02:03 acat: 18:02:27 so, i think now on esr60 there is no way to change the newtab page from blank to sth else 18:02:59 but now in esr68 it's possible to choose in about:preferences between blank and "Firefox Home", which is Firefox default new tab page 18:03:51 so i wanted to ask opinions on whether it's a good idea to allow that or not (because i think it's easier for us not to :) ) 18:04:57 So the problem is that Firefox Home relies on phoning home to Mozilla to load things on the page or ? 18:05:05 is #31575 the relevant ticket? 18:05:25 that's the technical problem yes, and i think it's not easy to disable these requests without patching 18:05:59 is the default about:home in 68? 18:06:04 but also there's the perspective of product/UX, do we want to allow "Firefox Home", given that the browser is not Firefox, but Tor Browser? 18:06:49 From a UX perspective, to me it makes more sense to replace the Firefox Home option with about:tor 18:07:00 yes, we don't, specially during end of year fundraising campaign 18:07:01 that was my thought, too 18:07:15 mcs +1 18:07:16 (re: using about:tor) 18:07:40 mcs +1 from me too 18:07:47 i also think it makes sense 18:07:59 I still want a way to have about:blank of course :) 18:08:05 i dunno that 1 trac user was pretty mad about it when i suggested it 18:08:13 does that seem like an easy patch? or is it complicated? 18:08:13 blank page seems also fine to me 18:08:27 as in, maybe we start off with changing the default to about:blank 18:08:44 ah wait, but are we talking about setting it as default? or about:blank as default with the option of changing to about:tor? 18:08:59 There are two issues: (1) the default new tab page and (2) what options do we expose in the UI 18:09:32 mcs, right. For (1) we aim for about:tor 18:10:09 for (2) about:tor or about:blank are the options? 18:10:27 i can comment on a ticket, if a ticket exists 18:10:28 new tab rght now is about:blank 18:10:36 yes 18:10:47 i actually like that more than about:tor 18:11:07 whhy? 18:11:12 oops, why? 18:11:22 hard to say 18:11:27 :) 18:11:39 i guess because it does not distract me when i just want to open a new tab 18:11:40 about:blank loads super fast and about:tor adds no value when I am opening a new tab (at least for me) 18:11:43 and load a url 18:11:49 on a slow/loaded computer, about:tor takes some time to load 18:11:50 both firefox and chrome has a new tab no blank, but then about:firefox or about:chrome is not a thing 18:12:06 mcs: brade: that#s a good point 18:12:20 *that's 18:12:53 what's the value of seeing about:tor every time when we open a new tab? 18:12:54 I agree that about:blank when you open a new tab is less distracting (just to add an additional data point... :) ) 18:13:19 i think it's a good welcome page 18:13:31 but that's different from the new tab scenario 18:13:39 i wonder why Mozilla decided to change it 18:13:44 maybe we can learn from them 18:13:55 acat: can you find the ticket where they made that decision? 18:14:00 im good with it, that is why we have an about:blank on new tabs nowadays 18:14:03 the one from mozilla has not text and only a search box, so less distracting than about:tor 18:14:06 maybe they didn't document it in the ticket, too 18:14:34 okay, this seems like a more general product decision 18:14:43 can we start with about:blank as the default 18:14:56 and decide if we want about:tor (or something else) in the future? 18:14:57 sysrqb: +1 18:15:23 Tor Browser *currently* have an about:blank in new tabs 18:15:35 not in esr68 18:15:43 i mean the alpha 18:16:03 but, yes, sounds good to me 18:16:07 +1, and for the other part, replacing "Firefox Home" option with "about:tor" in about:preferences UI? 18:16:13 which i guess leaves (2) 18:16:25 right 18:16:26 yeah, that sounds good to me 18:16:30 acat: do you have an estimate for how much time that'll require? 18:16:32 wfm too 18:16:35 for writing the patch? 18:16:48 should be easy 18:17:29 do you think 1 day or less? 18:18:01 #31575 already has a patch to not initialize firefox's about:tab, so we just need to change the UI 18:18:09 i think so 18:18:16 less than 1 day 18:18:30 GeKo, mcs, brade: do you think that's worth it? 18:18:49 I do 18:18:54 yep 18:19:04 okay, great, then acat, let's do it 18:19:20 good 18:19:33 anything else on this topic? 18:20:02 pili: you're up 18:20:07 current alpha has not about:tor at the start, that ticket contemplates it? https://share.riseup.net/#mQosCzYOqMkrEq6ljasMHA 18:20:49 yup, just a few things 18:21:01 first about the Bug Smash Fund, we raised money for it during last month and now we should spend it :) 18:21:14 antonela: we can discuss after the meeting 18:21:25 so if you see any bugs that fall outside of sponsor work that we need to fix, please add the "BugSmashFund" keyword in trac 18:21:25 (antonela: that's the first time i've seen that page...) 18:21:26 antonela: huh 18:21:30 me too 18:21:32 :) 18:21:35 I see pospeselr has already added some, thanks! 18:21:43 sysrqb: good good 18:22:02 * antonela is fast taking screenshots :) 18:22:07 :D 18:23:00 pili: re BugSmashFund, do you already have a query of tbb tickets without label? 18:23:15 antonela: nope but I could make one up :) 18:23:38 pili, oki we can overlap those and ux-team ones and find some -- for tomorrow ux-team meeting 18:23:47 pili: i'm guessing any tickets that don't currently have a sponsor assigned are available for this? 18:23:57 (as long as they're related to smashing bugs) 18:23:58 antonela: sounds good, I'll put it on my list :) 18:24:02 thanks! 18:24:03 sysrqb:yup 18:24:16 sounds good 18:24:42 okay, any other questions about this? 18:25:31 groot here 18:25:34 my other point is a gentle reminder to update the actual points fields once a ticket is closed in trac to reflect (more or less) how long it took to fix 18:25:49 and if you forget I will be very annoying for a few weeks and remind you :) 18:26:09 ha. 18:26:20 we wouldn't want that :) 18:26:37 okay, antonela 18:27:11 can we have pospeselr's patch in some alpha? is a huge change and i'd like to have community feedback on it :) 18:27:21 yes, the next 18:27:27 we are talking about #31286 18:27:31 GeKo: awesome, thanks! 18:27:52 hoo boy, not looking forward to that rebase 18:28:00 i know LOL 18:28:05 you should start soon :) 18:28:23 given that esr68.1.2 might be around earlier than expected 18:28:31 ugh i know 18:28:38 heh 18:28:42 ok, I'll see about getting that done asap 18:28:51 r.e. the screenshot Antonela posted, I have not seen that page either but the fix we made for #31457 should cause it to not be shown 18:29:13 yeah 18:29:14 (I base that statement on a quick reading of code) 18:29:27 that's been my assumtion, too 18:29:58 * antonela is running 9.0a6 18:30:05 okay. _hc did you have anything for this meeting? 18:30:10 or just sitting in today? 18:30:37 anyone have anything else they want to say before we finish this meeting? 18:30:48 mcs, GeKo, indeed seems related with profiles https://share.riseup.net/#OUfk5aSKoftJqy3JfJx1Lw 18:31:12 i am fine, thanks 18:31:38 great. have a good week everyone 18:31:45 #endmeeting