14:58:06 <richard> #startmeeting Tor Browser Weekly Meeting 2024-03-18
14:58:06 <MeetBot> Meeting started Mon Mar 18 14:58:06 2024 UTC.  The chair is richard. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:58:06 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
14:58:15 <richard> the pad per usual -> https://pad.riseup.net/p/tor-tbb-keep
14:59:45 <thorin> its just you and me richard
14:59:52 <ma1> ?
14:59:55 <richard> is it a holiday?
14:59:55 <richard> :3
15:00:01 <PieroV> Nope, I'm here
15:00:05 <ma1> me2
15:00:06 <dan_b> o/
15:00:18 <thorin> well no one waved handsies
15:00:22 <thorin> /o
15:00:23 <richard> hehe
15:01:39 <Jeremy_Rand_36C3[m]> Hi!
15:01:43 <bellatchau> o/
15:01:44 <richard> alright, on my end I signed+published 13.0.12 MB and we heard back from their QA that it's good to go
15:02:28 <richard> i've not yet looked at the android-backport situation, but presuming we're good there then we can build TB asap (unless the europeans have already started that)
15:03:09 <PieroV> Not started, not good with Android yet
15:03:30 <ma1> richard, re:secbackports we're good as far as we know (no drafts from moz yet, they had some editorial problems it seems)
15:03:35 <richard> i'll plan to optimistically prep the alphas this week, MB probably first so we have some time for any Android patches to get in
15:03:58 <PieroV> I'd like to get tor-browser!938 in the alpha
15:04:05 <PieroV> Unless we want to postpone the merge for after the alpha
15:04:09 <richard> I did hear from MB people on Friday that my pre-mature tor-browser build request did fail in some android stuffs, but i haven't looked at the logs
15:04:32 <PieroV> But given the small number of alphas we have we might want to get it in asap
15:05:03 <richard> oh and to keep people on the same page re 13.5 stabilising, we'e pushed it back to June after the lisbon meeting
15:05:16 <richard> giving us 3 scheduled alphas (counting march's before we stabilise)
15:05:26 <richard> and of course some unknown number of unscheduled ones
15:05:51 <richard> clairehuirst, dan_b: do we have any Android MRs coming down the pipe in the near future for 13.5a6?
15:06:33 <dan_b> yeah phase 1 of menu rework?
15:06:49 <dan_b> in a day or two?
15:07:02 <clairehurst> I can wrap up the one I'm working on
15:07:06 <dan_b> as per last week's release meeting
15:07:11 <richard> \o/
15:07:35 <richard> ok, PieroV in that case how about we get your tor-connect patches merged for this alpha
15:07:55 <richard> iirc they shouldn't affect functionality, they were just an internal cleanup?
15:08:02 <clairehurst> Right now, its mostly some QOL stuff but am making progress on the connection wizzard
15:08:32 <PieroV> richard: well, the refactor includes a couple of delicate changes
15:08:50 <PieroV> There's still a thread in the MR, but that would be a bigger change than I'd like for that MR
15:09:10 <PieroV> So, I've proposed a smaller change, I'm waiting for an answer there
15:09:15 <PieroV> For the rest it should be almost ready
15:09:26 <richard> ack I'll have a look
15:10:03 <richard> i think even if it's major we should get it in asap so we have time over the next few days to evaluate if/how much it breaks android in nightly
15:10:19 <richard> presuming that's wise
15:13:48 <richard> alright, i'm out of stuff, so let's move on to other topics+announcements?
15:15:38 <PieroV> I'm working on a diff-of-diffs script
15:16:13 <PieroV> But it isn't ready for production yet. I'd like to write tests etc etc before considering it ready for production
15:16:34 <dan_b> what does it do?
15:16:37 <PieroV> So, for the moment I consider it yet another of my scripts
15:17:13 <PieroV> dan_b: it helps reviewing rebases
15:17:46 <dan_b> cool
15:17:48 <PieroV> As a step of the rebase we usually create a diff of the whole patchset in both branches and then compare htem
15:17:56 <dan_b> right
15:18:08 <PieroV> But there's a lot of useless output (because the many diffs hopefully are the same)
15:18:33 <PieroV> This script goes file by file, and if nothing has changed between the two, it discards that file from the output
15:18:42 <PieroV> So that you possibly have a much smaller file
15:19:34 <PieroV> The comparison can be literal, or it can use some heuristic to remove changes that usually aren't meaningful for the purpose (such as index hashes, and offset changes)
15:19:44 <PieroV> Right now I'm using it to start writing a range-diff helper
15:20:07 <dan_b> oh interesting. that does sound nice!
15:20:27 <PieroV> That is basically a diff of diffs in small commit blocks (a "parent" commit and all fixups), since reading a range-diff when we squash commits becomes quite difficult
15:20:46 <PieroV> https://gitlab.torproject.org/pierov/lazy-scripts/-/blob/main/diff-of-diffs.py
15:21:08 <henry-x> cool!
15:22:33 <henry-x> I'm going to push out the Fluent migrations this week
15:22:42 <PieroV> Nice!
15:22:57 <henry-x> richard: are you generally available to review these this week, or should I assign someone else?
15:23:29 <richard> if i don't get to them today then you should assign them to someone else
15:23:37 <richard> henry-x^
15:23:43 <henry-x> ok
15:25:00 <richard> alright, any other topics to discuss or shall we adjourn?
15:25:09 <Jeremy_Rand_36C3[m]> just one quick note
15:25:27 <Jeremy_Rand_36C3[m]> richard: I understand the CFP for Lisbon is ending fairly soon
15:25:44 <Jeremy_Rand_36C3[m]> richard: I will probably be pinging you a few times to try to coordinate stuff for that
15:25:52 <richard> ack!
15:26:08 <richard> that reminds me i need to ping network people re the arti nerd fest sessiion
15:26:17 <Jeremy_Rand_36C3[m]> (the first ping of which will probably be shortly after this meeting)
15:26:35 <Jeremy_Rand_36C3[m]> that is all from my end -- Arthur is still sorting out the TorButton refactor
15:28:42 <richard> alright then folks
15:28:44 <richard> have a good week!
15:28:47 <richard> #endmeeting