17:01:10 #startmeeting network team meeting, 22nd november 2021 17:01:10 Meeting started Mon Nov 22 17:01:10 2021 UTC. The chair is ahf. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:01:10 Useful Commands: #action #agreed #help #info #idea #link #topic. 17:01:21 * ahf just got out of another meeting 17:01:30 our pad is at https://pad.riseup.net/p/tor-netteam-2021.1-keep 17:02:01 how are people's boards looking? https://gitlab.torproject.org/groups/tpo/core/-/boards 17:02:02 o/ 17:02:38 decent over here 17:02:38 o/ 17:02:52 i'll sync with cohosh later today about the s30 (and friends) tickets we have and figure out what needs to be prioritized there 17:03:31 * eta moves some things aroung 17:03:33 d* 17:03:50 eta: you have gotten your head around how all the board stuff works in the team? 17:04:10 think so (?) — I mean I was just moving things out of doing that were actually done, etc. 17:04:19 ya, that is pretty much it XD 17:04:26 awesome 17:04:49 dgoulet: anything we need to talk about regarding releases here? 17:05:10 nope 17:05:23 i am gonna try to get those warnings done this week that weasel reported 17:05:32 some of them are funny, some of them are weird 17:05:37 ok 17:06:01 eta: for arti#238, if you're not on that this week, mind if I take a look? 17:06:11 dgoulet: you have everything under control with NHT from what i can tell, i have not everything under control with "for anti-censorship team" label right now, but we sync about that later today to figure out what should be next on the plate there 17:06:26 we have no reminders, no announcements 17:06:45 thanks all for updating the pad with stuff! it looks good already 17:06:54 mikeperry: i think you can takeover now for s61 17:07:26 Ok last week a lot happened in the congestion control piece! 17:07:27 nickm, sure, go ahead 17:07:44 Last week, I finished running the Vegas queue parameter sims in Shadow. Queue parameter values that match the outbuf queue plus 1 TLS record of cells in the circuit queues, per hop, are performing the best. 17:07:50 I documented this in the experiments doc, and also reorganized it a bit to separate out the outbuf tuning. 17:08:00 dgoulet: could read over the new outbuf section 3 for sanity and let me know of any thoughts you have wrt extra things we might want to log? 17:08:10 https://gitlab.torproject.org/mikeperry/tor/-/blob/cc_shadow_experiments_v2/SHADOW_EXPERIMENTS.txt#L302 17:08:22 sure 17:08:38 great, thanks 17:08:52 jnewsome and hiro have been working hard on splitting the simulation and live perf measurement sources by country. They are running some final plotting tests on this in toy sims. 17:09:01 (This will be very helpful for further tuning and comparison to baseline, as it helps us separate the latency effects of location from the latency effects of changes we make. Yay!) 17:09:12 nice 17:09:34 I also updated the simulation doc with the next tuning stage, which is "slow start". I have a new list of named paramter sets, along with their git commit, so we can easily use gitlab to go through those: 17:09:41 https://gitlab.torproject.org/mikeperry/tor/-/blob/cc_shadow_experiments_v2/SHADOW_EXPERIMENTS.txt#L261 17:09:48 (I will be off starting Weds through the weekend, but I am hoping to keep the sim box warm with those during that time!) 17:10:14 ohhh, is this the holiday week in the US? 17:10:23 yeah 17:10:24 yup. Thu and Fri are company holidays 17:10:37 ahhhh, ok, that is very good to know. more CI time for the europeans! 17:10:43 heh 17:10:54 remember to take other balancing holidays! 17:11:03 ok, that is good to know. i think that menas we also wont be doing our thursday sync this week 17:11:49 I also finished up the last implementation pieces of Exit-side negotiation, and rebased dgoulet's work on onion service negotiation on top of that: https://gitlab.torproject.org/mikeperry/tor/-/commits/cc_negotiation_v4+svc 17:11:55 * eta will probably just take the US holidays off to keep things simpler 17:12:06 The Exit-side implementation is now in a new merge request (without dgoulet's work): https://gitlab.torproject.org/tpo/core/tor/-/merge_requests/495 17:12:17 It needs unit tests, but is otherwise ready for review. 17:12:26 For the unit tests, it seems fairly straightforward to add tests for the CPU worker queues, as well as onion_skin_server_handshake and onion_skin_client_handshake to cover negotiation. I will add these soon. 17:12:49 sweet 17:13:01 However, it seems like there's no existing test coverage of protover, extendinfo -> handshake choice, circuit completion, or the actualy cpuworker execution itself... 17:13:08 * nickm volunteers as Second Reviewer, or Third, depending on whatever you need 17:13:10 FWIW, I exercised it in Chutney, and we will be exercising it in Shadow once we get to the mixed client sims, in Round 6: 17:13:13 https://gitlab.torproject.org/mikeperry/tor/-/blob/cc_shadow_experiments_v2/SHADOW_EXPERIMENTS.txt#L430 17:13:22 Those sims will give us a lot of exercise of the code, and I also added a hidden torrc option to let us exercise it on an exit with our own clients regardless of consensus param. 17:13:41 nickm: yeah. I'm wondering if you could take a look at that MR and see if there's any additional tests you could easily add for those currently uncovered areas in tor, if it seems worth it? 17:14:24 sure; add a link to the coverage report and a list of the stuff I should look at? 17:15:24 I have a list of notes of stuff that I can translate into something more legible. does CI generate the coverage report, or do I need to do sth extra? 17:15:31 it does not 17:15:35 sadly 17:16:09 how do we get one? do I have to make one and upload it somewhere? 17:16:30 there is in doc/ somewhere a file describing how you get the gcov files out 17:16:34 ah, braino. I can make my own coverage report if you need 17:16:43 not thinking my best today :/ 17:17:22 hm, we could store main branch gcov reports in a gitlab page.. 17:17:40 next to the doxygen/rustdoc stuff 17:17:52 as far as reviewers, I think it def makes sense for dgoulet and nickm to reveiw this, in case triagebot disagrees. dgoulet needs to use some of it for onion svc negotiation anyway (that's why I did the rebase for him) 17:18:11 yes 17:19:02 you can override triage-bot by just setting a reviewer manually 17:19:10 it only handles tickets with no reviewer on 17:19:18 the onion service code does also test protover, but only for its descriptor version 17:19:23 I ran into a test failure there 17:19:36 so perhaps some of that can be repurposed or generalized? 17:22:01 moving on, at some point we should integrate the overload checking into shadow. does the latest tor alpha have the version of that that lets us tune the DNS rate? 17:23:20 no, it does not 17:23:23 are we satisfied with that generally, geko/dgoulet? 17:23:49 with what? 17:23:56 the overload lines 17:24:00 the new system is working as in as expected but the 1% right now is too low as far as we can tell 17:24:09 and we are investigating this DNS problem with our own Exit now 17:24:36 https://metrics.torproject.org/rs.html#details/50485E03CA39D393BD54D315CEBA65E6DD0FDDB9 it is 17:24:51 and teh overload we see is solely due to port 8074 open :) 17:25:19 what us 8074? 17:25:55 gadu-gadu 17:26:01 (seriously) 17:26:06 or rather, why does that nmatter? it is high bandwidth? 17:26:06 ‽ 17:26:16 o.O 17:26:31 wth is gadu-gadu doing here? :o 17:26:33 it's because almost all those dns requests over that port time out 17:26:40 i have no clue 17:26:51 it's weird 17:27:03 sounds like there is a dysfunctional botnet out there or a very fun day in ghidra with a gadu-gadu client there 17:27:05 GeKo: you mean, almost all DNS requests for connections to that port, right? 17:27:12 yes 17:27:19 whew! 17:27:21 sorry 17:27:33 * nickm was having horrible visions of DNS-over-gadu-gadu 17:27:41 :) 17:27:45 anyway 17:28:03 we need to dig into that and figure out a solution that is suable at the end 17:28:06 *usable 17:28:24 i think right now some exit operators turns their exits into non-exits 17:28:25 fun project lol, i was not expecting to see gadu gadu being mentioned in a tor meeting 17:28:33 because of the stupid overload 17:28:37 which is not optimal 17:28:48 can we tell them to disable gadu gadu for now? or is that not enough? 17:28:56 not enough 17:29:02 there are more pieces to the puzzle 17:29:08 ok 17:30:41 juga: I still have this sbws graph open to look at.. the CDF one.. sorry for that delay 17:30:55 how is sbws world going? 17:31:24 well, i added an item on the pad 17:31:40 mikeperry: good, not much going on last week 17:31:43 i think we need to return debugging the issue we are seeing on gabelmoo 17:31:50 juga: oh, okay 17:31:56 you are here 17:31:58 i still have to update the graph anyway, still waiting for data to be processed 17:32:10 didn't mean to jump ahead and give the summary ;) 17:32:31 GeKo: re. gabelmoo, i think we're fine, i'm going to update the issue 17:32:35 GeKo: np 17:32:41 that's all from my side 17:32:59 great 17:33:36 anything else for today? 17:34:06 that's all from me, unless geko has more 17:34:18 nope, i am good, thanks 17:35:00 let's call it then. hope folks enjoy the holiday here 17:35:10 monday next week is off for US folks too then, right? 17:35:25 or is that a normal workday 17:35:41 holidays is only thursday and friday 17:35:43 o/ 17:35:46 ah 17:35:46 ok 17:35:52 yup 17:35:52 perfect, see you all for netteam meeting next monday then 17:35:55 o/ 17:35:57 see y'all then! 17:35:58 #endmeeting