18:00:05 <GeKo> #startmeeting tor browser
18:00:05 <MeetBot> Meeting started Mon Jun 12 18:00:05 2017 UTC.  The chair is GeKo. Information about MeetBot at http://wiki.debian.org/MeetBot.
18:00:05 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
18:00:13 <GeKo> hi all!
18:00:32 <mcs> hi
18:00:35 <GeKo> another week, another tor browser meeting. let's get started with the status updates
18:00:54 <GeKo> who wants to go first today?
18:01:41 <mcs> me is still composing a status update but is almost ready :)
18:02:06 <GeKo> heh
18:02:15 <GeKo> so, i can go meanwhile i think
18:02:26 <GeKo> this week we got tor browser 7.0 out, woo!
18:02:36 <GeKo> thanks to all of you for your hard works
18:03:03 <GeKo> given the feedback we got so far it seems it is not outright garbage :)
18:03:28 <GeKo> i mainly worked on getting an overview over the feedback and on organizing the bugs
18:03:41 <GeKo> i have tagged them with `tbb-7.0-issues`
18:04:07 <GeKo> please look over them if you have time and add tickets from that pool to your work items as time permits
18:04:25 <GeKo> then i prepared 7.0.1 and 7.5a1 and build both with boklm
18:04:38 <GeKo> the 7.0.1 one is signed and uploaded on people-tpo in my builds dir
18:04:49 <GeKo> i'll do the same with 7.5a1 tomorrow
18:05:41 <GeKo> i then wrote some small fixes for #22554 and #22558 and #22560
18:05:53 <GeKo> and i resumed my work on #16010
18:06:15 <GeKo> the latter will be my main focus regarding ticket work next week
18:06:38 <GeKo> i plan to do some reviews and help getting the final switch to esr52 done
18:06:48 <mcs> when will the 7.0.1 and 7.5a1 releases go live? are we waiting on Mozilla at all?
18:07:00 <GeKo> i might start on updating the design document
18:07:16 <GeKo> we wait on the esr52.2.0 security fixes
18:07:40 <GeKo> so, the releases are for tomorrow/wednesday
18:07:52 <mcs> okay; thx
18:07:58 <GeKo> mcs: if you could give the bundles in 7.0.1 a quick test (including updater) that would be neat
18:08:08 <GeKo> my os x testing situation is bad right now
18:08:11 <mcs> GeKo: ack
18:08:16 <GeKo> with the minimum of 10.9
18:08:17 <mcs> or, can do
18:08:19 <GeKo> thanks
18:08:53 <GeKo> and finally i plan to do some vacation from 6/24-4/7 inclusive
18:08:58 <GeKo> i won't have internet
18:09:22 <GeKo> mike is helping out in case we need to do an emergency release (doing tagging etc.)
18:09:44 <GeKo> not sure who could do the second build we might want to ask ln5
18:09:52 <GeKo> that's it for me
18:09:53 <mcs> Enjoy your vacation; you have earned it.
18:09:59 <GeKo> ha, thanks.
18:10:37 <arthuredelstein> absolutely
18:11:01 <GeKo> :)
18:11:07 <GeKo> so, who is next?
18:11:09 * mcs will go next
18:11:14 * isabela is around
18:11:17 <mcs> Last week, Kathy and I finished #22496 and #22542.
18:11:21 <_hc> hi all, Hans here, I'm mostly lurking but happy to answre questions
18:11:30 <mcs> We worked on #22525 and #22543.
18:11:41 <mcs> (not done yet)
18:11:43 <mcs> We helped with miscellaneous bug triage and with #22558.
18:11:52 <GeKo> _hc: hi!
18:12:00 <mcs> We also reviewed several patches.
18:12:06 <mcs> This week, we will do some testing of Tor Browser 7.0.1 as requested by GeKo.
18:12:10 <mcs> We also plan to work on #18913 because fixing it may kill two 7.0 regressions (#21948 and #22535).
18:12:20 <mcs> Then we will work on other tickets marked with tbb-regression, tbb-7.0-must, and/or tbb-7.0-issues.
18:12:25 <mcs> That's all for us.
18:12:32 <GeKo> yay, i thought the same re #18913
18:13:12 <tjr> I can go next
18:13:22 <GeKo> mcs: oh, and have a look at #22553?
18:13:35 <GeKo> this looks surprisingly interesting :)
18:13:43 <GeKo> tjr: sorry, go!
18:13:54 <tjr> I've been working on getting MinGW closed out. I resolved a couple open bugs (thanks boklm!) and have a POC of the TC integration at the parent bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1330608
18:13:58 <tjr> The two known, large, outstanding issues are std::thread (which someone else from Mozilla has promised to take point on) and the Visual Studio binary (https://bugzilla.mozilla.org/show_bug.cgi?id=1365859)
18:14:02 <tjr> There is a third unknown concern about stylo coming into -central and requiring clang to build...
18:14:06 <tjr> I think I have a path forward for the VS binary. So previously, the graphics team ran a closed source shader compiler (fxc.exe) and pasted the output blob as hex in a header file. So we were shipping that unreproducible code before.
18:14:10 <tjr> Now, what I'm working on getting working is a linux version of FXC that will either use winlib to call the compile function in the windows .dll that implements the compilation function, or uses https://github.com/wine-mirror/wine/tree/master/dlls/d3dcompiler_43 as the compiler. I don't know if the wine code is interchangable with MSFT's dll.
18:14:19 <tjr> While looking into fxc I had a conversion with the graphics lead. he said "It looks like --enable-default-toolkit=cairo-windows is the default on windows so the MingGW mozconfig may not need to specify it at all"  At some point I'll get aorund to confirming that.
18:14:30 <tjr> One of the outstanding things for the TC integration is downloading the toolkit components from trustworthy sources. One of the things I download to built NSIS is a prebuilt version of zlib.dll compiled for Windows. I presume TB doesn't do this, so I was looking at how it built nsis.  The differences are:
18:14:37 <tjr> Mine: scons XGCC_W32_PREFIX=i686-w64-mingw32- SKIPUTILS="NSIS Menu" ZLIB_W32=../zlib-1.2.7-dll install
18:14:37 <tjr> Tor:  scons XGCC_W32_PREFIX=i686-w64-mingw32- SKIPUTILS='NSIS Menu' APPEND_CCFLAGS="-fgnu89-inline" VERSION=${NSIS_VER}   PREFIX=$INSTDIR/nsis install
18:15:02 <tjr> So if anyone knows anything about nsis and zlib and such, I'd be happy for direction
18:15:16 <tjr> <done, aside from comments/question>
18:15:47 <GeKo> did you do anything not in the taskcluster bug related bugs to get debug builds compiling?
18:16:09 <tjr> I haven't tried turning debug and seeing if that makes the browser run, if that's what you mean
18:16:15 <GeKo> no
18:16:19 <tjr> The patch I needed to get debug to compile has been merged into -central
18:16:23 <GeKo> just compiling
18:16:27 <GeKo> oh, okay.
18:16:50 <tjr> It was https://bugzilla.mozilla.org/show_bug.cgi?id=1332747
18:16:56 <GeKo> because i am currently struggling with #16010 and compiling with --enable-debug does not work
18:17:09 <GeKo> on one machine the compiler segfaults :)
18:17:13 <tjr> Oh!
18:17:29 <GeKo> and on the other there is something else i don't remember right now
18:17:32 <tjr> I have a patch for that! (Well, I experienced the same thing a couple times and the patch worked both times so maybe it will work for you too)
18:17:42 <GeKo> i'll keep poling
18:17:45 <GeKo> *poking
18:17:50 <GeKo> aha! neat
18:17:53 <GeKo> where is it?
18:18:06 <tjr> http://paste.ubuntu.com/24842850/
18:18:43 <GeKo> ah, indeed that's the same issue, thanks
18:19:16 <tjr> I'm overjoyed to actually be able to give you something for once :)
18:19:36 <GeKo> heh
18:19:50 <GeKo> okay, who is next today?
18:19:56 * boklm can go next
18:20:02 <GeKo> go!
18:20:20 <boklm> This past week I helped publish the 7.0 release, and build 7.0.1 and 7.5a1.
18:20:24 <boklm> For #6119 I set up a VM to test deployement of FPCentral, and opened some related tickets: #22585, #22586, #22587
18:20:46 <boklm> This week I'm planning to make patches for #22585 and #22586 (and send them to Pierre Laperdrix who made FPCentral, for review), and help with publishing 7.0.1 and 7.5a1
18:20:53 <boklm> That's it for me
18:21:20 * arthuredelstein can go
18:21:29 <arthuredelstein> Hi everyone. This week I wrote patches for #21617 and #21999
18:21:41 <arthuredelstein> I fixed my patch for #22343,
18:21:42 <arthuredelstein> and I reviewed patches for https://bugzilla.mozilla.org/1369303
18:22:04 <arthuredelstein> I also opened #22563 and #22584 -- I hope to investigate those at some point.
18:22:17 <arthuredelstein> This week I will look at any tbb-7.0-issues I can help with, plus I still ought to close out #21762 and #21756, so I will work on those if I have time.
18:22:45 <arthuredelstein> I will be taking two days of vacation at the end of this week as well as three at the start of the following week (but I will be our meeting on Monday).
18:22:59 <arthuredelstein> And the week after that I will be attending the Mozilla all hands meeting.
18:23:04 <arthuredelstein> That
18:23:07 <arthuredelstein> 's it for me
18:23:25 <isabela> (me wants to give 1 update and has 1 question)
18:23:37 <isabela> :)
18:23:41 <GeKo> thanks, nice work re #21617 fwiw!
18:23:50 <arthuredelstein> thanks :)
18:25:14 <GeKo> isabela: your turn it seems :)
18:25:19 <isabela> alright!
18:25:50 <isabela> 1. update on tor launcher automation work - i plan on udpate the brief this week based on the discussion we had on june 2nd
18:26:19 <isabela> also linda is working on wireframes for the flow she suggests on her paper - more on that soon
18:26:56 <isabela> 2. question - would the team want to sync with network team on blind selection? i think they learned some stuff and might be useful to pick their brain on it
18:27:24 <isabela> also looks like the job post is good for erin to move on with it, can you confirm?
18:27:27 <isabela> that's it
18:28:00 <GeKo> re 2: i think we could do that once the jobposting got out? not sure if there is much sync needed, though
18:28:18 <isabela> i mean for yall to ask them questions
18:28:27 <GeKo> apart from: you should look at that and that and that and should not do X and Y
18:28:51 <isabela> it seems that their evaluation is that it was not helpful
18:28:53 <isabela> that is why
18:29:05 <GeKo> isabela: re job posting i can look over it after the meeting
18:29:23 <isabela> k
18:29:23 <GeKo> hm
18:30:34 <GeKo> so, if it was indeed not helpful then we might indeed want to sync with them before we make a final decision on the process
18:31:03 <GeKo> i mean if we can easily avoid things that are not working for some reason i am all for it :)
18:31:10 <isabela> helpful - in the sense that it didn't really anonimized the candidates
18:31:14 <isabela> and it was some work for erin
18:31:20 <GeKo> oh, i see
18:31:35 <GeKo> yeah that part is hard
18:32:24 <isabela> alright, y'all can follow up on that later, is not a pressuring issue now  :)
18:32:28 <GeKo> i have no strong opinions on that one. it seemed to be interesting to try it out
18:32:38 <arthuredelstein> Kinda unrelated question regarding hiring the tbb dev: is the plan at a later stage to do a trial contract where candidate(s) fix 1 or 2 bugs?
18:32:55 <GeKo> but if it does not work anyway and causes just a lot of overhead then i am fine to skip it
18:33:03 <GeKo> arthuredelstein: yes
18:33:05 <isabela> arthuredelstein: yes, erin will ask the team for tickets to do that
18:33:12 <arthuredelstein> great
18:33:37 <GeKo> arthuredelstein: so, if you feel like looking into possible tickets, go for it
18:33:49 <arthuredelstein> Sure, I can have a look
18:34:30 <GeKo> i'll plan to do the same probably next week or the week after my vacation but having more thoughts on that are good
18:34:38 <arthuredelstein> I guess if we wanted to be perfectly fair, we would give everyone the same ticket :)
18:34:50 <arthuredelstein> But that seems kinda wasteful also...
18:34:53 <GeKo> that's tricky
18:35:30 <GeKo> yes and that
18:35:58 <GeKo> okay, do we have anyone else for status updates?
18:36:29 <GeKo> if not, do we have anything to discuss today?
18:36:44 <GeKo> i don't have any items fwiw
18:37:38 <mcs> I don’t have anything
18:39:32 <GeKo> alright, thanks all then and have a nice week *baf*
18:39:37 <GeKo> #endmeeting