17:02:26 <nickm> #startmeeting
17:02:26 <MeetBot> Meeting started Mon Jan 16 17:02:26 2017 UTC.  The chair is nickm. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:02:26 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
17:02:28 <nickm> Hi!  I think it's our regular network team meeting time!
17:02:46 <dgoulet> hi!
17:02:53 <dgoulet> asn is in travel mode he just told me
17:02:53 <nickm> It's also MLK day in the US, which is a federal holiday, so I'm totally not going to be surprised if folks don't show
17:03:02 <nickm> I hope he's doing ok
17:03:08 <nickm> dgoulet: how've you been?
17:03:12 <dgoulet> so we can skip it if you want :) no need to interrupt your holiday :)
17:03:25 <armadev> i happen to still be awake so i figured i'd show up
17:03:29 <archie5> i do github no one look https://github.com/archiebell/showme
17:03:41 <armadev> (my wheel-of-time-zones cannot be spun because it has come off of its hinges)
17:04:11 <dgoulet> nickm: I've been coding #20657 for the last 4 days... it is a bit more complicated than I anticipated :S, I'm at the "load options and configure" service step
17:04:15 <nickm> dgoulet: Well, I do kinda need to talk to somebody else who works on tor some time early this week to help figure out my priorities between now and freeze...
17:04:24 <nickm> but I could do that tomorrow morning if you'll be around
17:04:25 <dgoulet> ok
17:04:30 <asn> hey guys. i m indeed travelling. i have this for you:
17:04:32 <asn> Hello. I'm actually in a car right now (not driving) so connectivity is not
17:04:32 <asn> guaranteed! Last week I spent most of my time catching up with 2016 email
17:04:32 <asn> backlog. On the tor front, I updated my #20852 branch which got merged
17:04:32 <asn> upstream. I also reviewed various hidden service tickets that were on
17:04:34 <asn> review-group-14. This week, I plan to work more on prop224, and on pre-freeze
17:04:37 <asn> 0.3.0 stuff. EOF!
17:04:40 <isabela> oi o/
17:04:56 <nickm> (looks like we're having a meeting)
17:04:57 <nickm> hihi
17:05:05 <isabela> :)
17:05:10 <nickm> asn: I hope you're well; thanks for the updates and review!
17:05:24 <nickm> dgoulet: service-side isn't targetted for 0.3.0, is it?
17:06:12 <dgoulet> nickm: nope 031 but it has so much work to do and ideally we want it early merge window
17:06:41 <nickm> agreed
17:07:24 <nickm> Right now there are 86 tickets in 030, of which 74 don't have code for review/merge.
17:07:46 <nickm> and we plan to freeze on jan 24
17:07:55 <nickm> in 8 days
17:08:34 * armadev looks at #17605 like he was requested to (albeit a bit delayed)
17:08:47 <nickm> I opened review-group-15 for review...
17:08:54 <nickm> so that's there...
17:09:02 <dgoulet> nickm: I see 18 tickets that are "Enhancement"
17:09:06 <dgoulet> in the 030 milestone
17:09:24 <nickm> I think we haven't always been so good at distinguishing enhancement from defect
17:09:30 <dgoulet> which we should try to get merged before Jan 24th I guess
17:09:52 <nickm> for example, #20906 is clearly an enhancement
17:09:54 <nickm> and TBB wants it
17:10:29 <dgoulet> #20029 is an important one I believe
17:10:53 <nickm> I agree; what's the status on that?
17:11:00 <dgoulet> which could be in merge_ready actually as asn went over it
17:11:17 <dgoulet> (that is ready for nickm's eyes :)
17:11:21 <nickm> If you both like it, merge_ready it :)
17:11:24 <dgoulet> done
17:12:00 <nickm> Ther3e are also potential showstopper bugs, like the one underlying #21107 and all the ones from my guard code
17:12:10 <dgoulet> nickm: I'm sure we could do another pass at those 86 tickets and re-triage
17:12:14 <dgoulet> oh yes!
17:12:21 <isabela> dgoulet: +1
17:12:35 <isabela> i see 29 that status == new and no one assigned to it
17:12:36 <dgoulet> I can take some time today to do such a thing
17:12:43 <nickm> I would be happy to triage everything assigned to me, and everything "new".
17:12:56 <nickm> I won't assign all the new stuff, but I can throw some out
17:13:04 <dgoulet> right
17:13:16 <nickm> I'll also try to make sure "enhancement" vs "defect" is right.
17:13:23 <isabela> cool
17:13:26 <nickm> and mess with priorities
17:13:37 <nickm> oh hey, I didn't do my own status update:
17:13:48 <nickm> last week after I got back from RWC I ran around merging things
17:14:00 <nickm> oss-fuzz is live and running; I hope somebody will review my fuzzing branch so we can merge it
17:14:19 <nickm> and so we can get fuzzing on our new code too
17:15:11 <dgoulet> oh wow I owned 3 tickets in 030! I bet I can improve that :)
17:15:15 <dgoulet> -ed
17:16:05 <armadev> do i own any?
17:16:08 * isabela had a full week last week coming back after 2 weeks off - but got a lot in motion. I have a few questions for the complementary report I am writing to sponsoru / will follow up on that tomorrow since today is holiday.
17:16:24 <isabela> also new otf contract == sponsor4
17:16:42 <dgoulet> armadev: none
17:16:45 <armadev> woo
17:16:47 <isabela> nickm: should we still use -can and -must for sponsors code on trac?
17:16:53 <armadev> good thinking, past-me
17:16:55 <isabela> i was wondering about that
17:17:11 <nickm> I think that the sponsor4 stuff that I did at the top-level is all -must and the sub-tasks are all '-can'
17:17:16 <dgoulet> armadev: I,m sure there might be one or two tickets waiting for feedback from you but we can manage that :P
17:17:20 <isabela> nickm: ok
17:17:29 <asn> nickm: i can try to write patches for some of the guard issues? if that would help you?
17:18:39 <nickm> asn: if you think you know how to fix them, then either a patch or a "do it like this, nick!" explanation would help me
17:19:08 <asn> nickm: ack
17:19:13 <asn> dgoulet: also ack on merge_ready of #20029
17:19:21 <dgoulet> :)
17:20:12 <nickm> so my current plan then for the upcoming week is to review code and merge it, to do the abovementioned triage,to pick some essential features to implement and bugs to fix and work on those, & etc
17:20:21 <nickm> anything else I should have on my radar?
17:20:29 <dgoulet> sounds good
17:20:46 <nickm> I know roger wants stable releases.  Not planning to put those out this week, but could do some work towards them
17:21:33 <nickm> oh!  and surely, ewyatt will have some progress towards our network team hire that I will want to work on too
17:21:36 <isabela> nickm: i will have some follow up on sponsoru report and also on sponsor4 prep work
17:21:41 <nickm> ack
17:23:04 <nickm> asn: is there a reason #12595 is still open? I kinda feel like we did that
17:23:15 <asn> i think wecan close this one!
17:23:50 <nickm> done!
17:25:13 <dgoulet> so on my part, I'll do a triage run, review as much as I can and continue the work on #20657 as well (this week)
17:25:28 <nickm> thank you!
17:25:38 <dgoulet> please ping me if you _really_ need help on some imporatnt review or specific ticket
17:26:31 <nickm> ok
17:26:45 <nickm> can we take a look at review-group-15 together and see if there's anything without a reviewer on it?
17:27:06 <dgoulet> sure
17:27:21 <nickm> doom-url: https://trac.torproject.org/projects/tor/query?status=accepted&status=assigned&status=merge_ready&status=needs_information&status=needs_review&status=needs_revision&status=new&status=reopened&keywords=~review-group-15&col=id&col=summary&col=keywords&col=status&col=owner&col=type&col=priority&col=reviewer&order=priority
17:27:45 * dgoulet not looking at merge_ready
17:28:18 <nickm> I'll set myself as reviewer for #21134, #21193, and #20168, because I can.
17:28:29 <dgoulet> ah I can merge_ready one right away
17:28:59 <nickm> I actually do want another review on #19769.  armadev would be a good person for that: it's short but important
17:29:09 <asn> i think ireviewed #21193 and it's fine
17:29:17 <nickm> asn: merge_ready then?
17:29:25 <nickm> dgoulet: great?
17:29:27 <nickm> great!
17:29:31 <asn> ack will do
17:29:32 <nickm> asn: (also, thanks!)
17:29:38 <asn> np
17:29:51 <dgoulet> nickm: this is good #21118 but depends on the branch of #20921 that needs revision for fixing unit test
17:30:09 <nickm> ack
17:30:17 <nickm> mark merge_ready then, with caveat?
17:30:34 <nickm> (and set yourself as reviewer?)
17:31:01 <dgoulet> nickm: hrm #21118 is child ticket of #20921 so we'll have to fix the parent at some point anyway :)
17:31:07 <dgoulet> yeah reviewer it is
17:31:19 <nickm> I'll take on #17847, since I am about to ask for review on 3 of my branches :)
17:32:07 <nickm> My #18319 is very simple.  My #20824 is pretty simple.  My #20893 is medium-large, but valuable.  All need a reviewer :)
17:32:10 <dgoulet> and for #18319, teor has been quite in the loop for that, we could ask him
17:32:35 <nickm> We could, but I know he's busy, and we should have a backup plan.
17:32:55 <dgoulet> nickm: well hrm.. ticket18319 is quite straight forward
17:33:50 <dgoulet> nickm: so it really depends if the discussion ended up in favor of this change I guess
17:34:04 <dgoulet> (which incidently seems like a good thing to set in the testnet)
17:34:20 <dgoulet> " This seems to be working fine (and consistently) on the test network:"
17:34:26 <dgoulet> ah teor is one step ahead :)
17:34:37 <dgoulet> nickm: I say go for it
17:34:44 <nickm> cool; say so on the ticket? :)
17:34:58 <dgoulet> sure
17:35:44 <dgoulet> boom
17:35:48 <nickm> thanks!
17:37:49 <nickm> any more discussion topics for today, or shall we call this meeting over and go on with the triage?
17:38:01 * dgoulet is good
17:38:14 * isabela is good
17:39:00 <nickm> then
17:39:02 <nickm> #endmeeting