16:09:10 <asn> #startmeeting prop224 implementation plan
16:09:10 <MeetBot> Meeting started Mon May 30 16:09:10 2016 UTC.  The chair is asn. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:09:10 <MeetBot> Useful Commands: #action #agreed #help #info #idea #link #topic.
16:09:12 <asn> ah nice
16:09:17 <asn> aight
16:09:43 <asn> OK so I made some notes of the things I consider TODO short-term wrt prop224
16:10:09 <dgoulet> go
16:10:31 <asn> OK, so there are both spec and code things that we need to do on the short-term
16:10:38 <asn> let me start by spec, which is shorter:
16:10:44 <asn> IMO we need to do the following ASAP:
16:10:57 <asn> - Finalize descriptor stuff (AFAIK almost ready but special has some fixups)
16:11:12 <asn> - Finalize client auth stuff (not sure where we are here, but we need to pin this down RSN)
16:11:40 <asn> - Finalize time period stuff (this is not super urgent, but there are thigns we discussed in montreal that have not been written down in the spec. and I need to do ASAP before I forget things.)
16:11:47 <asn> these are the three spec things I consider "urgent"
16:11:58 <asn> mainly because the implementation is blocking
16:12:15 <asn> EOF for now
16:12:20 <asn> any comments?
16:12:45 <dgoulet> sounds good to me and agree on the urgent
16:12:50 <asn> aight
16:12:53 <special> mm
16:12:56 <dgoulet> we have most of them finalized except maybe client auth I think?
16:13:01 <asn> right
16:13:02 <special> yes
16:13:11 <asn> client auth might require some discussion back & forth
16:13:48 <asn> ok
16:13:52 <asn> so that's that on the spec side
16:13:57 <asn> i guess you don't have anything else that is urgent
16:14:08 <special> I suspect there are also some cell related changes that will become "urgent" once we start working on implementing those cells
16:14:14 <asn> special: agreed!
16:14:47 <asn> unfortunately, we will probably get additional insight on things when we start implementing.
16:14:55 <dgoulet> yah
16:15:05 <asn> so let me proceed with the code tasks that I consider short-term TODO:
16:15:18 <asn> (we should probably put these lists on a pad later on this meeting)
16:15:42 <asn> - Refactor rend_data_t so that we can do descriptor upload/fetching from HSDirs
16:15:53 <asn> -- Finalize HSDir-related code (depends on above)
16:16:26 <asn> - Start implementing cells (maybe start from ESTABLISH_INTRO aka #19043)
16:16:46 <asn> - Finalize prop250 stuff (take care of review, and the SR state open bugs)
16:17:05 <asn> These are the coding tasks I think are relevant for the next days/weeks.
16:17:23 <dgoulet> agree, 250 and rend_data_t are my priorities
16:17:28 <special> - Finalize descriptor code (& all of the tests for it)
16:17:29 <asn> I also had a note about asking teor whether he can spend some time to think how we can make chutney more useful for future prop224 testing
16:17:34 <special> unless that was part of "HSDir code"
16:17:43 <asn> special: yes that's what i meant
16:17:52 <special> I think they are different things
16:17:54 <dgoulet> yeah
16:17:55 <asn> ah
16:17:59 <asn> you probably know better
16:18:09 <dgoulet> encode/decode, hsdir cache, hsdir upload/download basically
16:18:19 <dgoulet> the later is the one we need rend_data_t
16:18:34 <dgoulet> #17238
16:18:38 <dgoulet> see child tickets
16:18:45 <dgoulet> we could do better breakdown ^
16:19:16 <asn> hm ok
16:19:18 <asn> let me launch a pad
16:19:21 <asn> maybe it will help us
16:19:22 <asn> coordinate this
16:19:44 <dgoulet> asn: we do have a pad for 224 HSDir btw
16:20:18 <asn> ok let's use this then: https://storm.torproject.org/shared/HoK_R0_ohIZa4e2Ef52vrhfiVC1dzDD658vyK14bCV2
16:20:31 <asn> i think this is the link to the prop224 pad [omg leak]
16:20:53 <dgoulet> that one is on tor-dev@ somewhere I think unless your link is RW rights :)
16:21:12 <asn> ok let's go to the bot
16:21:15 <asn> bottom
16:23:13 <asn> ok
16:23:15 <special> what is the extra indentation meant to imply
16:23:31 <asn> i was trying to imply dependencies
16:23:50 <asn> in the sense that rend_data_t refactoring is required to get the HSDir thing together
16:24:01 <asn> i think
16:24:10 <asn> but maybe that's not useful data
16:24:26 <special> it might be, just wasn't appropriate for the descriptor part. it's better now.
16:24:36 <asn> :)
16:25:05 <asn> OK
16:25:06 <dgoulet> ok there some ticket numbers
16:25:09 <asn> thx
16:25:14 <asn> do you guys feel we should add more stuff in there?
16:25:26 <asn> i think if we split those tasks between us, we will be busy for N days
16:25:29 <dgoulet> if this is for the short-term, it's good I think
16:25:31 <dgoulet> only for*
16:25:44 <asn> where N is probably greater than 5 and less than 25
16:25:45 * armadev creates #19204 from one of the montreal todos
16:25:46 <special> if we were to add more stuff, it'd be "more cells"?
16:26:25 <dgoulet> armadev: I was wondering the other day, why exactly this is needed for 224 ?
16:26:48 <asn> #19024 and #19204 are both related, and anagrams!
16:27:53 <armadev> dgoulet: i think it isn't. except if we want to change stuff that uses rend_service_descriptor_t, we're going to have an easier time of it if the struct is easier to use.
16:28:02 <dgoulet> right ok
16:28:14 <armadev> i'm just following through with a plausible idea that nick had :)
16:29:25 <asn> if we think that ticket is worth doing, we should make it a child of another ticket, otherwise it will be lost in the void
16:29:35 <dgoulet> so I've already started a bit at the meeting the rend_data_t part so answering nickm's review of 250 and rend_data_t is what I can do in the short term which I can transition in finalizing the fetch/store logic of HSDir
16:30:10 <dgoulet> special: seems you have the encode/decode under control? or not?
16:30:15 <special> yes
16:30:18 <asn> i'd also be interested in doing some prop250. i feel that the design has drifted from my brain during the past weeks, and I'd like to review it again.
16:30:37 <asn> so you guys agree we should try to assign names to these tasks?
16:30:42 <asn> i will put my name in the obvious parts
16:30:43 <special> yes
16:30:45 <dgoulet> yeah
16:30:54 <armadev> asn: if we want it to be a child, it could be the child of one of the "publish new rend descs to new hsdirs" tasks?
16:31:15 <dgoulet> I'm the owner of #19024 so I guess my name is on it
16:31:36 <dgoulet> I'll make a child ticket for "HSDir fetch/store logic"
16:32:01 <asn> dgoulet: can you also take armadev's ticket and place it somewhere in your HSDir ticket infrastructure?
16:32:16 <asn> i can also take over the ESTABLISH_INTRO thing if you guys are fine with it
16:32:23 <special> totally
16:32:40 <dgoulet> asn: hrm... #19204 is kind of not 224 but if it's tagged tor-hs, we'll not forget about it :)
16:32:49 <armadev> i'd love to do some code review. but what i want most is to not be presented with a 6000 line patch that mostly just moves stuff around but also made a couple of simple changes at the same time.
16:33:06 <armadev> i looked at one of the branches and was immediately faced with such a 6000 line patch. i couldn't proceed.
16:33:13 <special> one of what branches?
16:33:25 <armadev> i don't know. something in montreal.
16:33:34 <dgoulet> not sure we have a branch that big and complicated for 224, I think you  looked at the prop250 branch :)
16:33:39 <dgoulet> armadev: and yes it's big
16:33:45 <armadev> plausible!
16:34:41 <asn> ok i think we have names attached to the crucial tickets in there
16:34:50 <asn> s/tickets/tasks/
16:35:06 <asn> personally, i plan to start with prop250. then move to spec. then move to cells.
16:35:09 <dgoulet> there added mine for the subtask of finalizing because that's currently mostly my code
16:35:31 <asn> we can touch base again in a week or two. we are all pretty active on IRC, so we can communicate on this as the days go by?
16:35:38 <special> mhm
16:35:43 <dgoulet> asn: I can help you with time period if needed, it's still fresh in my memory
16:35:44 <special> I have some distractions happening this week
16:36:03 <asn> dgoulet: ok, i will make a patch and then you can review it?
16:36:07 <dgoulet> perfect
16:36:24 <asn> that's why I added my name to the other spec patches as well. because I plan to spend some time replying to special's client auth thread, etc.
16:36:27 <special> am very excited to read the time period document with a fresh mind and see if it makes sense
16:36:28 <armadev> is there a page that lists the most important needs-review 224 and 250 branches/patches/commits? :)
16:36:54 <dgoulet> armadev: query with "prop250" and "prop224" in the Summary
16:37:17 <dgoulet> armadev: they both have super meta top parent ticket, #16943 and #12424
16:37:54 <dgoulet> armadev: and also in the pad asn shared above :)
16:38:27 <asn> armadev: i think we will have a final final prop250 branch in the upcoming week. you might want to hold your review moments for some of that.
16:38:40 <asn> big words there, but let's see.
16:38:50 <dgoulet> "final final" you mean nickm approved?
16:39:20 <asn> hmm maybe not "ready to merge by nickm", but more like "asn and dgoulet and testnet are all happy with it"
16:39:41 <dgoulet> ok
16:39:51 <armadev> great. carry on, let me know if you run across a thing this week that i would be especially helpful for.
16:39:58 <armadev> my schedule gets ugly again on saturday.
16:40:46 * armadev proceeds to open those other tickets he said he would open based on nickm's suggestions
16:40:51 <asn> ack
16:41:17 <asn> dgoulet: special: ok are we happy?
16:41:20 <dgoulet> I am
16:41:24 <special> yes
16:41:40 <asn> great
16:41:43 <asn> #endmeeting